dont check for svg support, temporary fix for typescript 2.2 bug #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamothe
requested changes
Feb 22, 2017
src/utils/FeatureDetectionUtils.ts
Outdated
| } | ||
|
|
||
| declare var document: IDocument; | ||
|
|
||
| export class FeatureDetectionUtils { |
There was a problem hiding this comment.
If it's not used anywhere else.... Remove it.
I would remove the file completely, and then we don't need this fix.
There was a problem hiding this comment.
I did not remove the FeatureDetectionUtils file since its function is publicly exposed.
There was a problem hiding this comment.
Yeah, but it's not documented.
Anything that is not publicly documented, it's fair game to remove it.
olamothe
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SVG supported is supported in all browsers, removed the check.
http://caniuse.com/#feat=svg
https://developers.coveo.com/display/public/JsSearch/Browser+Support
Issue with the definition file for document.implementation.hasFeature microsoft/TypeScript#14062
Also fixed a
variable used before declarationerror in ResultsList, introduced in typescript 2.2I did not remove the FeatureDetectionUtils file since it's publicly exposed.