Add build step to clear CloudFront cache on official build #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dms1lva
approved these changes
Nov 23, 2017
samisayegh
approved these changes
Nov 23, 2017
| console.log(colors.red(error.message)); | ||
| console.log(colors.red('*************')); | ||
| exec('travis_terminate 1'); | ||
| throw error; |
There was a problem hiding this comment.
Is it necessary to throw this error even though you are terminating the process on line 39? Are we catching or relying on node.js to catch? If the latter, wouldn't that crash the server?
Edit: I guess this will only crash the travis instance which isn't a big deal. But still, why do it if we terminate on the line before?
There was a problem hiding this comment.
True, the throw is not 100% needed.
It's going to print the error in the console though, which can be useful to debug.
The travis terminate will cause the travis build to fail. The server will not "crash".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used for hotfix.
I changed the naming of the files/chunk that we produce to append the hash generated by webpack, so that chunks do not get overwritten.
The entry point name does not change (CoveoJsSearch.js, CoveoJsSearch.Lazy.js).
I did that because if we simply override the file name, there is a possible downtime in search page between the couple of seconds that it takes to finish all the "deploy" steps in travis, and then to start the "after_deploy" step.
By not overriding old files, this means the "old" entry point still works properly as we are uploading new files, then, when the deploy is finished, we can invalidate old files (so the "new" entry point will begin serving new chunks).
In theory this should mean no downtime, and minimal waiting time between an hotfix being built, and it being available (couple of seconds at worst).