Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use chrome browser for cypress tests #2904

Merged
merged 33 commits into from May 23, 2023

Conversation

mrrajamanickam-coveo
Copy link
Contributor

@mrrajamanickam-coveo mrrajamanickam-coveo commented May 16, 2023

  • Also
  • Merged changes from ci: add retry in CI for failed cypress test suites #2911 to test them together
    • Adds retry to failed cypress actions and a couple of recommended vscode extensions (KIT-2481)
  • Refactor bunch of flaky test suites, primarily by restructuring before setup to before each (KIT-2448)
  • No changes to test exec time observed (averaging around ~5min per suite as before with electron)
    • Unless a test section is retried on failure (which could add 2-3x depending on times failed to the test sections that were retried)

TODO

  • Fix error in 3 pkgs: Cypress version 10.0.0 no longer supports cypress.json. - possibly surfaced due to switching to system node (v18)

https://coveord.atlassian.net/browse/KIT-2488

@github-actions
Copy link

github-actions bot commented May 16, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

package-lock.json
  • node-getopt@0.3.2
  • retry-cli@0.7.0
package.json
  • retry-cli@0.7.0
packages/atomic-hosted-page/package.json
  • cypress@10.8.0
  • cypress@9.7.0
packages/samples/headless-react/package.json
  • cypress@10.8.0
packages/samples/stencil/package.json
  • cypress@10.8.0
  • cypress@9.7.0
packages/samples/vuejs/package.json
  • cypress@10.8.0
  • cypress@9.7.0

@github-actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 176.7 176.7 0
search 320.9 320.9 0
insight 281.4 281.4 0
product-listing 219.6 219.6 0
product-recommendation 151.7 151.7 0
recommendation 185.5 185.5 0

@mrrajamanickam-coveo mrrajamanickam-coveo enabled auto-merge (squash) May 17, 2023 17:33
@mrrajamanickam-coveo mrrajamanickam-coveo enabled auto-merge (squash) May 18, 2023 01:09
@mrrajamanickam-coveo mrrajamanickam-coveo requested a review from a team as a code owner May 18, 2023 21:32
@mrrajamanickam-coveo
Copy link
Contributor Author

@olamothe Can you please review the changes since you last reviewed.
The only failure now is from Review / Dependency Review - probably from a change in master

The following dependencies have incompatible licenses:
package-lock.json » axe-core@4.7.0 – License: MPL-2.0
Error: Dependency review detected incompatible licenses.

Looks like the new version is getting pulled as a transitive dep. Should we pin to an older version?

├─┬ @coveo/atomic@2.29.0 -> ./packages/atomic
│ ├── axe-core@4.4.3
│ └─┬ cypress-axe@1.0.0
│ └── axe-core@4.4.3 deduped
└─┬ @coveo/headless-react-samples@0.0.0 -> ./packages/samples/headless-react
└─┬ react-scripts@5.0.1
└─┬ eslint-config-react-app@7.0.1
└─┬ eslint-plugin-jsx-a11y@6.7.1
└── axe-core@4.7.0

@mrrajamanickam-coveo mrrajamanickam-coveo merged commit d2ffb73 into master May 23, 2023
32 checks passed
@mrrajamanickam-coveo mrrajamanickam-coveo deleted the KIT-2478_chrome_browser_cypress branch May 23, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants