-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat svcc 3827 knowledge headless controller #4062
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35e3482
to
f1c3aaa
Compare
f40e4fb
to
4319a77
Compare
4949876
to
34b976c
Compare
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
6fcaa85
to
9120336
Compare
34b976c
to
3b39ab8
Compare
3b39ab8
to
d98aa1f
Compare
9120336
to
f0be471
Compare
6e561dc
to
b135f09
Compare
d98aa1f
to
6ad5665
Compare
6ad5665
to
d98aa1f
Compare
50e9beb
to
e40a55c
Compare
This is now obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller using the knowledge-api-client
Summary
Refactored the current generatedAnswer controllers to maximize re-usability between the current stream pattern using a stream ID from the searchAPI and the new AnswerAPI streaming directly from a query.
headless-core-generated-answer controller
Removed the logic listening to the search to make it more generic. All the state related to the UI component management is left untouched.
headless-searchapi-generated-answer controller
Is now the main controller used by all the implementation prior to the knowledgeAPI stream. And whenever the interface is not configured to use the new client, it will still use the
headless-searchapi-generated-answer
controller.headless-knowledge-generated-answer controller
Its the controller used to connect the new client stream with the
generated-answer
state. I decided to keep the same state slice that was already used by the atomic and quantic implementation. I only mapped the required state keys from the client to the controller state with listeners dispatching the right state updating action when required.Testing
I decided to duplicate a lot of test because I did not want any change made to the
headless-core-generated-answer
controller to affect the other controller extending it.I did not find a way to properly test what is happening inside the listener, unfortunately