Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): add tests for atomic-commerce-search-box #4085

Merged
merged 14 commits into from
Jul 3, 2024
Merged

test(atomic): add tests for atomic-commerce-search-box #4085

merged 14 commits into from
Jul 3, 2024

Conversation

fpbrault
Copy link
Contributor

This PR adds more tests for atomic-commerce-search-box

https://coveord.atlassian.net/browse/KIT-3246

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 12, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.9 204.9 0
commerce 293.4 293.4 0
search 372.6 372.6 0
insight 352.6 352.6 0
product-listing 267 267 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.4 365.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fpbrault fpbrault marked this pull request as ready for review June 12, 2024 15:46
@fpbrault fpbrault requested a review from a team as a code owner June 12, 2024 15:46
@fpbrault fpbrault added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 4d4323b Jul 3, 2024
87 checks passed
@fpbrault fpbrault deleted the KIT-3246 branch July 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fpbrault @olamothe @y-lakhdar @fbeaudoincoveo