fix(commerce): remove executeFirstSearch & friend from commerce engine
#4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
Spuffynism
force-pushed
the
feat-capi-1068-remove-execute-first-search
branch
from
472d780
to
48115ee
Compare
Spuffynism
commented
Jun 14, 2024
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
…remove-execute-first-search
Spuffynism
commented
Jun 20, 2024
packages/atomic/src/components/commerce/atomic-commerce-interface/atomic-commerce-interface.tsx
Outdated
Show resolved
Hide resolved
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
olamothe
approved these changes
Jun 25, 2024
packages/atomic/src/components/commerce/atomic-commerce-interface/atomic-commerce-interface.tsx
Outdated
Show resolved
Hide resolved
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
approved these changes
Jun 25, 2024
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
…om:coveo/ui-kit into feat-capi-1068-remove-execute-first-search
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fbeaudoincoveo
approved these changes
Jun 27, 2024
packages/atomic/src/components/commerce/atomic-commerce-interface/atomic-commerce-interface.tsx
Outdated
Show resolved
Hide resolved
packages/atomic-react/src/components/commerce/CommerceInterfaceWrapper.tsx
Outdated
Show resolved
Hide resolved
…om:coveo/ui-kit into feat-capi-1068-remove-execute-first-search
Spuffynism
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CAPI-1068
As the commerce engine is solution-type agnostic, it should not expose search-specific methods on its engine.
I adjusted the atomic commerce interface to take the change into consideration. However, I think we should remove
executeFirstSearchfrom it as well since it's used for search and listings. Thoughts?