Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomic): atomic-commerce-no-products #4098

Merged
merged 8 commits into from
Jun 26, 2024
Merged

test(atomic): atomic-commerce-no-products #4098

merged 8 commits into from
Jun 26, 2024

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Jun 17, 2024

  • Add E2E tests for atomic-commerce-no-products
  • Include "No Results" message in atomic-aria-live

https://coveord.atlassian.net/browse/KIT-3252

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 17, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.9 204.9 0
commerce 293.1 293.1 0
search 372.4 372.4 0
insight 352.4 352.4 0
product-listing 267 267 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.2 365.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@y-lakhdar y-lakhdar changed the title test(atomic): add no-products e2e tests test(atomic): atomic-commerce-no-products Jun 18, 2024
@y-lakhdar y-lakhdar added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@y-lakhdar y-lakhdar added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2024
@y-lakhdar y-lakhdar added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jun 26, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@y-lakhdar y-lakhdar added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit 6ad5665 Jun 26, 2024
87 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3252 branch June 26, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants