fix(atomic): make sure to escape any HTML generated by the AI model #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
approved these changes
Jun 17, 2024
olamothe
approved these changes
Jun 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
y-lakhdar
approved these changes
Jun 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fbeaudoincoveo
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVCC-3883
An issue was reported where the AI model would generate an answer containing HTML elements (as examples). For instance, the generated answer would only contain an opening tag. The HTML element was not escaped and prevented the answer from being entirely displayed.
This PR fixes the issue by escaping any HTML coming from the AI model.