Validate the configurations even when syncing

cli/sync.go

@@ -1,13 +1,20 @@
 package cli
 
 import (
+	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 )
 
 var syncCmd = &cobra.Command{
 	Use:   "sync",
 	Short: "Fetches credentials and syncs them to targets",
 	Run: func(cmd *cobra.Command, args []string) {
+		if !configuration.Sources.ValidateConfiguration() {
+			log.Fatal("The sources section of the config file is invalid")
+		}
+		if !configuration.Targets.ValidateConfiguration() {
+			log.Fatal("The targets section of the config file is invalid")
+		}
 		configuration.Sync()
 	},
 }

credentials/source_s3.go

@@ -6,6 +6,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/session"
 	"github.com/aws/aws-sdk-go/service/s3"
+	log "github.com/sirupsen/logrus"
 )
 
 type AWSS3Source struct {
@@ -39,5 +40,13 @@ func (source *AWSS3Source) Type() string {
 }
 
 func (source *AWSS3Source) ValidateConfiguration() bool {
-	return len(source.Bucket) > 0 && len(source.Key) > 0
+	if source.Bucket == "" {
+		log.Errorf("S3 sources must define a bucket")
+		return false
+	}
+	if source.Key == "" {
+		log.Errorf("S3 sources must define a key")
+		return false
+	}
+	return true
 }

credentials/source_secretsmanager.go

@@ -8,6 +8,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws/credentials/stscreds"
 	"github.com/aws/aws-sdk-go/aws/session"
 	"github.com/aws/aws-sdk-go/service/secretsmanager"
+	log "github.com/sirupsen/logrus"
 )
 
 type AWSSecretsManagerSource struct {
@@ -41,8 +42,6 @@ func (source *AWSSecretsManagerSource) Credentials() ([]Credentials, error) {
 		}
 	} else if source.SecretID != "" {
 		secretIDs = append(secretIDs, source.SecretID)
-	} else {
-		return nil, fmt.Errorf("Either `secret_id` or `secret_prefix` must be defined")
 	}
 
 	credentials := []Credentials{}
@@ -68,5 +67,9 @@ func (source *AWSSecretsManagerSource) Type() string {
 }
 
 func (source *AWSSecretsManagerSource) ValidateConfiguration() bool {
-	return len(source.SecretID) > 0
+	if source.SecretID == "" && source.SecretPrefix == "" {
+		log.Error("Either `secret_id` or `secret_prefix` must be defined on a secretsmanager source")
+		return false
+	}
+	return true
 }