Add S3 and SecretsManager validation tests

credentials/source_s3_test.go

@@ -0,0 +1,41 @@
+package credentials
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestS3SourceValidate(t *testing.T) {
+	t.Parallel()
+
+	cases := []struct {
+		name          string
+		source        *AWSS3Source
+		expectedError error
+	}{
+		{
+			name:          "No bucket",
+			source:        &AWSS3Source{Key: "test"},
+			expectedError: fmt.Errorf("S3 sources must define a bucket"),
+		},
+		{
+			name:          "No key",
+			source:        &AWSS3Source{Bucket: "bucket"},
+			expectedError: fmt.Errorf("S3 sources must define a key"),
+		},
+		{
+			name:          "Valid",
+			source:        &AWSS3Source{Bucket: "bucket", Key: "test"},
+			expectedError: nil,
+		},
+	}
+
+	for _, tt := range cases {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, "Amazon S3", tt.source.Type())
+			assert.Equal(t, tt.expectedError, tt.source.ValidateConfiguration())
+		})
+	}
+}

credentials/source_secretsmanager.go

@@ -80,7 +80,7 @@ func (source *AWSSecretsManagerSource) Type() string {
 
 // ValidateConfiguration verifies that the source's attributes are valid
 func (source *AWSSecretsManagerSource) ValidateConfiguration() error {
-	if source.SecretID == "" && source.SecretPrefix == "" {
+	if (source.SecretID == "" && source.SecretPrefix == "") || (source.SecretID != "" && source.SecretPrefix != "") {
 		return fmt.Errorf("Either `secret_id` or `secret_prefix` must be defined on a secretsmanager source")
 	}
 	return nil

credentials/source_secretsmanager_test.go

@@ -0,0 +1,46 @@
+package credentials
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestSecretsManagerSourceValidate(t *testing.T) {
+	t.Parallel()
+
+	cases := []struct {
+		name          string
+		source        *AWSSecretsManagerSource
+		expectedError error
+	}{
+		{
+			name:          "No config",
+			source:        &AWSSecretsManagerSource{},
+			expectedError: fmt.Errorf("Either `secret_id` or `secret_prefix` must be defined on a secretsmanager source"),
+		},
+		{
+			name:          "Both secret ID and prefix",
+			source:        &AWSSecretsManagerSource{SecretID: "test", SecretPrefix: "test2"},
+			expectedError: fmt.Errorf("Either `secret_id` or `secret_prefix` must be defined on a secretsmanager source"),
+		},
+		{
+			name:          "Valid with only ID",
+			source:        &AWSSecretsManagerSource{SecretID: "test"},
+			expectedError: nil,
+		},
+		{
+			name:          "Valid with only prefix",
+			source:        &AWSSecretsManagerSource{SecretPrefix: "test"},
+			expectedError: nil,
+		},
+	}
+
+	for _, tt := range cases {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, "Amazon SecretsManager", tt.source.Type())
+			assert.Equal(t, tt.expectedError, tt.source.ValidateConfiguration())
+		})
+	}
+}