Only log errors getting credentials to a specific format if all formats fail #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulRahmanAlHamali
approved these changes
Nov 7, 2021
pballandras
approved these changes
Nov 8, 2021
| @@ -99,11 +99,23 @@ func getCredentialsFromBytes(byteArray []byte) ([]Credentials, error) { | |||
| ) | |||
|
|
|||
| methods := []func(bytes []byte) ([]map[string]interface{}, error){tryReadingList, tryReadingMapOfCredentials, tryReadingSingleCredential} | |||
| var success = false | |||
There was a problem hiding this comment.
The most go-diomatic way to init with a value is the walrus := operator like so
Suggested change
| var success = false | |
| success := false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to troubleshoot run erros when the log is polluted by errors like:
The way the code is now, these errors are normal: all formats are tried until one works or all fail.
With this change, these errors will only be logged if reading fail for all formats