Add message to warn users about default install path #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pballandras
commented
Mar 9, 2023
| # Mac OSX | ||
| echo "Since MacOS Ventura (13.X), the default install path is owned by 'root'." | ||
| echo "You can fix this by either" | ||
| echo " 1. Running 'sudo chown -R $(id -un):$(id -gn) $TGF_PATH'." |
There was a problem hiding this comment.
The $(...) parts are evaluated during the display of the message, comments?
There was a problem hiding this comment.
maybe @dotboris can recommend something from his bag of tricks.
There was a problem hiding this comment.
Honestly it's fine. That's how you do it. I know that there's a $USER variable you could rely on but I feel that your implementation would work in more cases.
JHeilCoveo
approved these changes
Mar 10, 2023
dotboris
approved these changes
Mar 14, 2023
| # Mac OSX | ||
| echo "Since MacOS Ventura (13.X), the default install path is owned by 'root'." | ||
| echo "You can fix this by either" | ||
| echo " 1. Running 'sudo chown -R $(id -un):$(id -gn) $TGF_PATH'." |
There was a problem hiding this comment.
Honestly it's fine. That's how you do it. I know that there's a $USER variable you could rely on but I feel that your implementation would work in more cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with MacOS Ventura (13.X), the
/usr/local/binfolder is owned by root on new installs.This aims to clarify to users with new macs what is going on and guide them when the installer fails.
This PR adds:
This PR doesn't add: