Docker + config + Fix ssl listener fixes #9
Conversation
supported anymore in the uabot repo. REmove hack from docker file. Now it should work nicely. https://coveord.atlassian.net/browse/DA-720
supported anymore in the uabot repo. REmove hack from docker file. Now it should work nicely. https://coveord.atlassian.net/browse/DA-720
|
Why did you rename the vendor/ folder? |
| @@ -26,12 +26,6 @@ func (builder *botConfigurationBuilder) WithLanguages(languages []string) *botCo | |||
| return builder | |||
| } | |||
|
|
|||
| func (builder *botConfigurationBuilder) AllAnonymous() *botConfigurationBuilder { | |||
There was a problem hiding this comment.
You could keep the function even if you do not use it anymore?
There was a problem hiding this comment.
What was the error?
The existence of a function shouldn't prevent you from building :)
server/handlers.go
Outdated
| @@ -147,8 +147,10 @@ func validateConfig(config *explorerlib.Config) error { | |||
| func Stop(writter http.ResponseWriter, request *http.Request) { | |||
| Vars := mux.Vars(request) | |||
| id, _ := uuid.FromString(Vars["id"]) | |||
| scenariolib.Info.Printf("Stopping worker") | |||
There was a problem hiding this comment.
Please use Println(), Printf() is meant to be used with a format string.
Println will give you a new line every time.
|
@erocheleau I didn't do any rename/move. I don't have that in my local repo. ¯_(ツ)_/¯ |
server/handlers.go
Outdated
| close(quitChannels[id]) | ||
| delete(quitChannels, id) | ||
| scenariolib.Info.Printf("Worker stopped") |
Fixed orgId support https://coveord.atlassian.net/browse/DA-720
| @@ -26,12 +26,6 @@ func (builder *botConfigurationBuilder) WithLanguages(languages []string) *botCo | |||
| return builder | |||
| } | |||
|
|
|||
| func (builder *botConfigurationBuilder) AllAnonymous() *botConfigurationBuilder { | |||
| builder.config.AllowAnonymous = true | |||
There was a problem hiding this comment.
@erocheleau that prevented the build to be successful.
The Config object in uabot repo doesn't have the AllowAnonymous property anymore.
There was a problem hiding this comment.
ah, yes, change it so it sets the AnonymousThreshold float64 to 1 instead. And there is no longer a need to allowAnonymous.
There was a problem hiding this comment.
Just remove the line builder.config.AllowAnonymous = true and that should be it.
# Conflicts: # Dockerfile # main.go
With all those commits the build and run of the docker image is without flaws.