Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to manual coverage.py parser #121

Closed
wants to merge 1 commit into from

Conversation

mike-burns
Copy link
Contributor

The new parser fails for many people on CI because it requires a command-line tool that is proving tricky to guarantee installed and, if installed, tricky to guarantee we can find it.

As a stopgap, revert that change and push that release out. The work in the commit is good, but we need to focus more on ensuring access to the command-line tool.

This reverts commit ac469ac. Closes #119

Closes # (issue)

⚡ Summary

☑️ Checklist

  • Add specs

The new parser fails for many people on CI because it requires a
command-line tool that is proving tricky to guarantee installed and, if
installed, tricky to guarantee we can find it.

As a stopgap, revert that change and push that release out. The work in
the commit is good, but we need to focus more on ensuring access to the
command-line tool.

This reverts commit ac469ac. Closes #119
@mike-burns
Copy link
Contributor Author

Duplicate of #120.

@mike-burns mike-burns closed this Apr 10, 2024
Copy link

Pull Request Test Coverage Report for Build 8638364209

Details

  • 50 of 54 (92.59%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 93.719%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/coverage_reporter/parsers/coveragepy_parser.cr 50 54 92.59%
Files with Coverage Reduction New Missed Lines %
src/coverage_reporter/api/jobs.cr 1 97.92%
Totals Coverage Status
Change from base Build 8619630776: -0.2%
Covered Lines: 940
Relevant Lines: 1003

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to upload report using coverage-reporter v0.6.8
1 participant