Use build num instead of workflow id #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
added a commit
to josegonzalez/coverage-reporter
that referenced
this pull request
May 12, 2023
This is more correct and easier for developers to understand. See coverallsapp/orb#15 for details.
|
I think this can be closed - the upstream repo should be the place where the change is applied, and the coveralls folks have decided against it. |
|
Yes, unfortunately there's no workflow-scoped unique number that can be used instead of workflow id. So, to make it robust, we use workflow id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup is misleading.
It is showing on coveralls as the build number, but in reality it is the workflow id of the build
Built in CircleCI env variables here
I think it would be much nicer to see
1rather than611d45e9-ed30-4eda-bff0-60130de2e8af