fix: expand paths before checking for existence #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, all characters in the `coverage_file` value are treated as literal characters in the path. The combinations of `~`, `./`, or `../` won't be treated as expected, causing weird build failures for users. Note that if the file doesn't exist, then the path will resolve to empty string, which is fine. Closes coverallsapp#33
|
Thank you for the fix. You can check it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, all characters in the
coverage_filevalue are treated as literal characters in the path. The combinations of~,./, or../won't be treated as expected, causing weird build failures for users.Note that if the file doesn't exist, then the path will resolve to empty string, which is fine.
Aside, I used a separate variable so that the logging would reflect the originally passed in value and not the resolved path.
Closes #33