Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loss in coverage #1043

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

daveMueller
Copy link
Collaborator

closes #1037

@daveMueller
Copy link
Collaborator Author

Mhh I don't have a problem running the integration tests locally. Any idea?

@JSkimming
Copy link

Mhh I don't have a problem running the integration tests locally. Any idea?

@daveMueller I think the tests are failing due to this #865 known issue. I get this occasionally, can you trigger a rebuild?

@MarcoRossignoli
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli MarcoRossignoli added bug Something isn't working tenet-coverage Issue related to possible incorrect coverage labels Jan 14, 2021
@MarcoRossignoli
Copy link
Collaborator

Mhh I don't have a problem running the integration tests locally. Any idea?

Yep sometimes we hit known issue also on our tests for msbuild/.NET Tool

@MarcoRossignoli MarcoRossignoli changed the title Bugfix for 1037 Fix double-digit loss in coverage Jan 14, 2021
@MarcoRossignoli MarcoRossignoli changed the title Fix double-digit loss in coverage Fix loss in coverage Jan 14, 2021
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SuperMegaThanks Dave!

@AraHaan
Copy link

AraHaan commented Apr 9, 2022

Did this regress again @MarcoRossignoli?

@MarcoRossignoli
Copy link
Collaborator

Mmm what you mean?for what I know we don't have this issue anymore

@daveMueller daveMueller deleted the 1037 branch April 13, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tenet-coverage Issue related to possible incorrect coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-digit losses of coverage using coverlet.msbuild 3.0.0
4 participants