Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of Npath complexity for the OpenCover reports #1058

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Implementation of Npath complexity for the OpenCover reports #1058

merged 2 commits into from
Mar 14, 2021

Conversation

benjaminZale
Copy link
Contributor

Resolves #1057 and #132:

Npath complexity is now calculated for OpenCover Reports

@MarcoRossignoli MarcoRossignoli added the tenet-reporters Issue related to coverage output files(reporters) label Jan 17, 2021
@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Jan 17, 2021 •
edited

Can you confirm you've adapted this https://github.com/OpenCover/opencover/blob/master/main/OpenCover.Framework/Persistance/BasePersistance.cs#L419 ?

If so can you add comment+link above method? i.e. "Taken from...."

@benjaminZale
Copy link
Contributor Author

Can you confirm you've adapted this https://github.com/OpenCover/opencover/blob/master/main/OpenCover.Framework/Persistance/BasePersistance.cs#L419 ?

If so can you add comment+link above method? i.e. "Taken from...."

Done

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Jan 30, 2021 •
edited

Can you update tests https://github.com/coverlet-coverage/coverlet/blob/master/test/coverlet.core.tests/Reporters/OpenCoverReporterTests.cs?

@MarcoRossignoli
Copy link
Collaborator

@benjaminZale any news on this?

MarcoRossignoli
MarcoRossignoli approved these changes Mar 14, 2021
View reviewed changes
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@MarcoRossignoli
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli MarcoRossignoli merged commit c745dbc into coverlet-coverage:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@tonerdo tonerdo Awaiting requested review from tonerdo

@petli petli Awaiting requested review from petli

Assignees
No one assigned
Labels
tenet-reporters Issue related to coverage output files(reporters)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opencover nPathComplexity is hardcoded to 0
2 participants
@benjaminZale @MarcoRossignoli