Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add multiple threshold #379 #1123

Merged

Conversation

pbmiguel
Copy link
Contributor

Me and @FranciscoSousaDeveloper tried to continue this Pull Request but we had no permission. So this Pull Request is the continuation of #385 with rebase and updated documentation.

Basically, this Pull Request enables the specification of multiple threshold values.

@dnfadmin
Copy link

dnfadmin commented Mar 11, 2021

CLA assistant check
All CLA requirements met.

@pbmiguel
Copy link
Contributor Author

@MarcoRossignoli can you please validate?

@MarcoRossignoli MarcoRossignoli added driver-console Issue related to dotnet net tool driver driver-msbuild Issue related to msbuild driver labels Mar 13, 2021
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes and here we go!
Thanks!

src/coverlet.core/CoverageResult.cs Outdated Show resolved Hide resolved
src/coverlet.console/Program.cs Outdated Show resolved Hide resolved
src/coverlet.msbuild.tasks/CoverageResultTask.cs Outdated Show resolved Hide resolved
@MarcoRossignoli
Copy link
Collaborator

@pbmiguel seems that rebase didn't go well...I see 22 files changed you've included some old commits.

@pbmiguel pbmiguel force-pushed the feat/add-multiple-threshold branch from 3d665db to 356bf27 Compare March 20, 2021 11:47
@pbmiguel
Copy link
Contributor Author

@MarcoRossignoli, it's fixed now.

You can see the new changes here

src/coverlet.console/Program.cs Show resolved Hide resolved
src/coverlet.console/Program.cs Outdated Show resolved Hide resolved
src/coverlet.core/CoverageResult.cs Outdated Show resolved Hide resolved
@pbmiguel pbmiguel force-pushed the feat/add-multiple-threshold branch from 356bf27 to b8111fc Compare March 21, 2021 11:17
@pbmiguel pbmiguel force-pushed the feat/add-multiple-threshold branch from b8111fc to 99cb653 Compare March 22, 2021 17:01
Copy link
Collaborator

@daveMueller daveMueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MarcoRossignoli MarcoRossignoli merged commit c74b9c4 into coverlet-coverage:master Mar 30, 2021
@MarcoRossignoli
Copy link
Collaborator

thanks @pbmiguel!

@pbmiguel
Copy link
Contributor Author

pbmiguel commented Apr 1, 2021

@MarcoRossignoli, when will you expected this to be released? because the last release was in February

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Apr 1, 2021

We don't have ETA yet, need to schedule, I'll take a look at issue list to understand if we want more fix before release, anyway you can dogfood our nighty build if you want, so you'll help us with testing also ☺️

https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver-console Issue related to dotnet net tool driver driver-msbuild Issue related to msbuild driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants