Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip assigned auto properties and records #1159

Merged
merged 3 commits into from
May 5, 2021
Merged

Skip assigned auto properties and records #1159

merged 3 commits into from
May 5, 2021

Conversation

daveMueller
Copy link
Collaborator

closes #1139

@daveMueller daveMueller mentioned this pull request May 3, 2021
Closed
MarcoRossignoli
MarcoRossignoli approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, LGTM, thanks a lot!

src/coverlet.core/Symbols/CecilSymbolHelper.cs Show resolved Hide resolved
src/coverlet.core/Symbols/CecilSymbolHelper.cs Outdated Show resolved Hide resolved
src/coverlet.core/Symbols/CecilSymbolHelper.cs Show resolved Hide resolved
@MarcoRossignoli MarcoRossignoli added the tenet-coverage Issue related to possible incorrect coverage label May 4, 2021
@MarcoRossignoli MarcoRossignoli merged commit 8a59bd5 into coverlet-coverage:master May 5, 2021
@MarcoRossignoli
Copy link
Collaborator

REMINDER: changelog @daveMueller

@daveMueller daveMueller deleted the 1139_AutoProps branch May 5, 2021 21:21
@daveMueller daveMueller mentioned this pull request Dec 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

Assignees
No one assigned
Labels
tenet-coverage Issue related to possible incorrect coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SkipAutoProps to work for records as well.
2 participants
@daveMueller @MarcoRossignoli