Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch exception #367

Merged
merged 1 commit into from Mar 14, 2019
Merged

fix: catch exception #367

merged 1 commit into from Mar 14, 2019

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Mar 12, 2019

This pr catches exceptions caused by invalid pdb's.

Eg Oracle.ManagedDataAccess 18.3.0 is failing.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #367 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   87.02%   87.05%   +0.02%     
==========================================
  Files          31       31              
  Lines        3107     3114       +7     
==========================================
+ Hits         2704     2711       +7     
  Misses        403      403

1 similar comment
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #367 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   87.02%   87.05%   +0.02%     
==========================================
  Files          31       31              
  Lines        3107     3114       +7     
==========================================
+ Hits         2704     2711       +7     
  Misses        403      403

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank's

/cc @tonerdo

@tonerdo tonerdo merged commit f08506e into coverlet-coverage:master Mar 14, 2019
@viceice viceice deleted the fix/invalid-pdb branch May 6, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants