moved frequency time logic into the parser method #21 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configparser/configparser.go
Outdated
| readabletime, _ := time.ParseDuration(freq) | ||
|
|
||
| // If the time specified is less than 1 second, treat the value as seconds | ||
| if readabletime <= time.Duration(1000000000) { |
There was a problem hiding this comment.
Just for readability, can this be written as 1 * time.Second ?
configparser/configparser.go
Outdated
| log.Println("The value of Frequency was not valid, defaulting to 1m from", freq) | ||
| } else { | ||
| // Convert the nanoseconds to seconds | ||
| readabletime = time.Duration(intreadable * 1000000000) |
There was a problem hiding this comment.
Same here. I guess the 1 * may be unnecessary so just * time.Second?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new field in the sink Struct called TimeFrequency and moved the logic added into the Sinkworker to the Configparser in a new function to then populate the TimeFrequency field of the sink struct with a time.Durration type value for use elsewhere.