Implement a common interface for the various resource types #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjohnson
changed the title
grep-ir
approved these changes
Jan 15, 2020
Instead of having branched logic for each type all over the place, make them implement a common interface that provides a String() and Map() method. Then the workers can be simplified Also, start to flesh out the code for the workers more Lastly, naked returns are apparently bad practice, so fix up to stop using those
chrisjohnson
force-pushed
the
implement-common-interface
branch
from
f180fae
to
7ac3442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can pass one common type into the templating package and it doesn't need to have special code variants for each type. Same with the workers. Also start stubbing out some of the remaining necessary functionality.
Also, apparently naked returns are bad practice, so clean up the code here to explicitly return named values
TODO: The
Map()method needs to be fleshed out