Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character and content-length fixes #2

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

brettphillips05
Copy link
Contributor

Added support for "complex" artist and track names that have characters which will cause issues, in addition to the occasional invalid content-length in header

  1. Changed songtitle variable to include all commas in song name or title. Example fix: Earth, Wind & Fire - September.mp3 came up as Earth.mp3
  2. Remove / and replace - when it exists in artists or track names because most OS does not support a file name with a slash. Example: AC/DC - You Shook Me All Night Long track name would cause script to error out because of the /. Change filename to AC-DC - You Shook Me All Night Long
  3. For an unknown reason, some content-length set in the header was not correct and cURL would bomb out. Chose to --ignore-content-length in cURL, which will download the file correctly.

…en it exists in artists or track names because most OS does not support a file name with a slash and added cURL command to ignore content length since some downloads would end prematurely because of the content length.
@covertg covertg merged commit d21ddb9 into covertg:master Jan 24, 2017
@covertg
Copy link
Owner

covertg commented Jan 24, 2017

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants