Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display post submission time with time and day in Store Card #144

Closed
Sapeksha opened this issue Apr 8, 2020 · 3 comments
Closed

Display post submission time with time and day in Store Card #144

Sapeksha opened this issue Apr 8, 2020 · 3 comments
Assignees
@xsihe
Labels
good first issue Good for newcomers prioritized feature Extra attention is needed

Comments

@Sapeksha
Copy link

Sapeksha commented Apr 8, 2020

When displaying post submission time on each submission, format the time to show the time at which the submission was created as well as show the day it was posted.

Instead of "2 days ago", display time as "6:45 pm on Sunday". We can follow the below convention for this:

  • updates in the last 24 hours: "6:45 pm"
  • updates > 24 hours in the last week: "6.45 pm on Sunday"
  • updates > 1 week: "6:45 pm 11 days ago"
@Sapeksha Sapeksha added good first issue Good for newcomers prioritized feature Extra attention is needed labels Apr 8, 2020
@asanjeevrao asanjeevrao mentioned this issue Apr 8, 2020
Open
@xsihe
Copy link
Contributor

xsihe commented Apr 16, 2020

If no one is working on this right now, I'd like to take a go at it.

@arjunattam
Copy link
Member

Go for it! Feel free to ping/tag me if you need any help :)

xsihe added a commit to xsihe/covid-maps that referenced this issue Apr 16, 2020
@xsihe
Issue covid-maps#144: Updated timestamp to show submission time and day
4a6635f
xsihe added a commit to xsihe/covid-maps that referenced this issue Apr 16, 2020
@xsihe
Issue covid-maps#144: updated timestamp to use date-fns
a300e03
Siddharth11 added a commit that referenced this issue Apr 16, 2020
@Siddharth11
Merge pull request #254 from xsihe/EntriesGroup-timestamp
db5523c 
Issue #144: Updated timestamp to show submission time and day
@Siddharth11
Copy link
Member

closed by #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xsihe xsihe

Labels
good first issue Good for newcomers prioritized feature Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arjunattam @Sapeksha @Siddharth11 @xsihe