Display fatalities in dashboard #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When merging please don't squash to keep all contributors :-) |
|
Supersedes #94 |
|
@poldrack if we merge this do you think we should update the text as well? |
|
yes, though I think it only needs minor changes - that is, instead of
saying "cases" say "cases or fatalities" - LMK know if you want me to do
it. in fact I think it would be fine to merge without changes for now and
make them later.
cheers
rp
…On Sun, Mar 29, 2020 at 9:48 AM Emmanuelle Gouillart < ***@***.***> wrote:
@poldrack <https://github.com/poldrack> if we merge this do you think we
should update the text as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGUVEE3EIQS6G6GXFK6KJ3RJ53V7ANCNFSM4LWBDG6A>
.
--
Russell A. Poldrack
Albert Ray Lang Professor of Psychology
Professor (by courtesy) of Computer Science
Bldg. 420, Jordan Hall
Stanford University
Stanford, CA 94305
poldrack@stanford.edu
http://www.poldracklab.org/
|
|
This does not seem significantly slower even on mobile phone. +1 for merge. After this, if @poldrack can help with reworking the text. I think that it would be important to mention quite high that we are just plotting the data as reported, and not accounting for reporting biases. It is more and more clear that some countries have huge reporting biases in their casualties. |
|
will do once it's merged
…On Sun, Mar 29, 2020 at 12:18 PM Gael Varoquaux ***@***.***> wrote:
This does not seem significantly slower.
+1 for merge. After this, if @poldrack <https://github.com/poldrack> can
help with reworking the text. I think that it would be important to mention
quite high that we are just plotting the data as reported, and not
accounting for reporting biases. It is more and more clear that some
countries have huge reporting biases in their casualties.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGUVEDQUQYIFXKIKEC76JDRJ6NHNANCNFSM4LWBDG6A>
.
--
Russell A. Poldrack
Albert Ray Lang Professor of Psychology
Professor (by courtesy) of Computer Science
Bldg. 420, Jordan Hall
Stanford University
Stanford, CA 94305
poldrack@stanford.edu
http://www.poldracklab.org/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has been mostly done by @mrastgoo, and I did some Javascript finishing touches.
It is now possible to toggle between confirmed cases and fatalities thanks to a radio button. Note that we could use a similar approach for log vs linear, which would remove the bug that everything resets to linear when a country is added. It's just a bit involved to code because you have to detect which radio button was clicked.