Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Unregister user even with an error #82

Merged

Conversation

michalsrutek
Copy link
Contributor

Is there a reason not to let the user unregister if there's been an error in the unregister request? If not, then this is a fix to the following.

Steps to reproduce

  • Register on a device A
  • Register on a device B using the same number
  • Unregister on A
  • Try to unregister on B - an error alert shown, nothing happens
  • Now the on device B can't ever get unregistered

@michalsrutek
Copy link
Contributor Author

@ddmus @augard Any thoughts?

@augard
Copy link
Member

augard commented Apr 18, 2020

I will like more if it will just skip when error is "Error Domain=com.firebase.functions Code=16 "Chybějící autentizace" UserInfo={NSLocalizedDescription=Chybějící autentizace}"

@michalsrutek
Copy link
Contributor Author

What about other possible errors? With this, the user is left hanging logged-in in app without the ability to do anything about it.
I was somehow able to get at least one error different from the one you mentioned.

@augard
Copy link
Member

augard commented Apr 18, 2020

You can uninstall app. I don't want to ignore that you can have error on backend or problem with internet connection and you private information still stored on server.

@michalsrutek michalsrutek force-pushed the ms-unregister-user-even-with-error branch from 445954f to 3ae9463 Compare April 18, 2020 15:10
@michalsrutek
Copy link
Contributor Author

Haven't come across the error you mentioned, but now, the error is ignored iff the user has been already deleted. Also, rebased.

@augard augard merged commit 9cd8f2b into covid19cz:master Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants