Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Website hangs when searched for essentials on smartphone #1486

Closed
nprabhav opened this issue Apr 24, 2020 · 7 comments · Fixed by #1546
Closed

Website hangs when searched for essentials on smartphone #1486

nprabhav opened this issue Apr 24, 2020 · 7 comments · Fixed by #1546
Assignees
@raxhvl
Labels
Essentials All bugs/Enhancement related to Essentials. Priority: High After critical issues are fixed, these should be dealt with before any further issues Status: Completed Nothing further to be done with this issue
Projects
Roadmap

Comments

@nprabhav
Copy link

nprabhav commented Apr 24, 2020 •
edited
Loading

Describe the bug
Site crashes when we search for essentials on Smartphones.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Menu
  2. Click on Essentials
  3. Click on Search
  4. Type anything in Search Keyword
  5. See error

Expected behavior
At least it should return 'No results found' when the search fails or it should return say top x items related to the search.

Screenshots

issue1

Smartphone (please complete the following information):

  • Device: OnePlus6T
  • OS: Android 10 OxygenOS 10.3.2
  • Browser Chrome 80.0.3987.149
  • Version 80.0.3987.149
@bee-rickey bee-rickey added the Essentials All bugs/Enhancement related to Essentials. label Apr 24, 2020
@shuklaayush shuklaayush mentioned this issue Apr 24, 2020
Closed
@shuklaayush shuklaayush added Status: Available Reply with /claim to assign to you and removed Status: Review Needed labels Apr 24, 2020
@sudevschiz sudevschiz added the Priority: High After critical issues are fixed, these should be dealt with before any further issues label Apr 24, 2020
@raxhvl
Copy link
Contributor

raxhvl commented Apr 24, 2020

I can look into this.

@jeremyphilemon jeremyphilemon added this to Available in Roadmap via automation Apr 25, 2020
@jeremyphilemon jeremyphilemon assigned raxhvl and unassigned nikita-11 Apr 25, 2020
@jeremyphilemon jeremyphilemon added Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be and removed Status: Available Reply with /claim to assign to you labels Apr 25, 2020
@jeremyphilemon jeremyphilemon moved this from Available to Claimed in Roadmap Apr 25, 2020
@raxhvl raxhvl mentioned this issue Apr 25, 2020
Closed
@itsplavika
Copy link

The same issue is happening on chrome Mac as well, the page becomes unresponsive
Screenshot 2020-04-25 at 6 18 20 PM

@nikita-11
Copy link
Contributor

@ravindranrahul Are you working on this? This is a critical fix. Will need to add it soon.

@nikita-11
Copy link
Contributor

Else we planned to disable search bar functionality for a while. If possible, Let me know the updates on this.

@raxhvl
Copy link
Contributor

raxhvl commented Apr 25, 2020

Yes, am working on this, meanwhile can we hotfix this by disabling search?

@raxhvl
Copy link
Contributor

raxhvl commented Apr 25, 2020

It would be ideal if we merge #1532 and i can add the fixes on this page too.

@chinmaydalvi chinmaydalvi mentioned this issue Apr 25, 2020
Merged
4 tasks
@jeremyphilemon
Copy link
Collaborator

@ravindranrahul

For issue #1486 solution might be the same which I have implemented.
Use the inbuilt useDebounce hook which is already defined in react-script - @chinmaydalvi

@raxhvl raxhvl mentioned this issue Apr 25, 2020
Merged
4 tasks
@jeremyphilemon jeremyphilemon moved this from Claimed to In progress in Roadmap Apr 25, 2020
Roadmap automation moved this from In progress to Done Apr 25, 2020
@jeremyphilemon jeremyphilemon added Status: Completed Nothing further to be done with this issue and removed Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be labels Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@raxhvl raxhvl

Labels
Essentials All bugs/Enhancement related to Essentials. Priority: High After critical issues are fixed, these should be dealt with before any further issues Status: Completed Nothing further to be done with this issue
Projects
Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Debounce input events in essentials search
8 participants
@sudevschiz @raxhvl @nprabhav @jeremyphilemon @shuklaayush @itsplavika @nikita-11 @bee-rickey