Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Adding support for localization using i18n #21

Closed
AdityaKhanna opened this issue Mar 23, 2020 · 8 comments · Fixed by #357 or #1862
Closed

Adding support for localization using i18n #21

AdityaKhanna opened this issue Mar 23, 2020 · 8 comments · Fixed by #357 or #1862
Assignees
Labels
Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be Status: In Progress

Comments

@AdityaKhanna
Copy link

AdityaKhanna commented Mar 23, 2020

As discussed, we need to add support for regional languages for the users to access the information. Finer details still need to be ironed out.

@jeremyphilemon
Copy link
Collaborator

I think having a language selector would be a much better ux flow!

Here's a quick mockup I made to on how we can implement the language selection.

Screen Shot 2020-03-23 at 1 25 26 PM

@JunaidBabu JunaidBabu added this to Low priority in Website main Mar 24, 2020
@sangamesh1439
Copy link

Do we really need localisation support ?

@sauravpratihar
Copy link

Instead of all region languages I think we have to include Hindi as for now.
Suggestion?

@AdityaKhanna
Copy link
Author

@sangamesh1439 it's been marked as low priority - that should answer your question about whether it's needed.

@sauravpratihar - the framework to add support for different languages stays the same - once it has been done for any one other language, it can be easily scaled for other languages. We can start with Hindi as the first language. But other languages would need to follow up soon

@harshzalavadiya
Copy link
Contributor

harshzalavadiya commented Mar 25, 2020

Can I take this issue?

I have created a very quick demo for showing translation setup using react-i18next
https://covid19india-react-three.now.sh/

  • as of now it's only translating single key I'll add other keys and submit PR

also is this project using any sort of formatter/linter because I have seen many unused imports, will it be okay if I cleanup imports and add prettier?

Update: It's done and demo at https://covid19india-react-three.now.sh/

@Nijanthane
Copy link

Regionalization would be a good thing to have!

@jeremyphilemon
Copy link
Collaborator

@harshzalavadiya mentioned you in #432

@rohandebsarkar
Copy link

In language selector bengali is written as "বাঙালি" where as the original spelling is "বাংলা", I would request you to change it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Claimed It's clear what the subject of the issue is about, and what the resolution should be Status: In Progress
Projects
No open projects
Website main
  
Low priority
Development

Successfully merging a pull request may close this issue.

8 participants