Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

localization support #132

Closed
wants to merge 8 commits into from
Closed

localization support #132

wants to merge 8 commits into from

Conversation

harshzalavadiya
Copy link
Contributor

@harshzalavadiya harshzalavadiya commented Mar 25, 2020

Closes #98, #21

As of now I have added some mostly used languages more can be added on demand reference https://en.wikipedia.org/wiki/Languages_of_India

Languages added

  • Hindi
  • English
  • Bengali
  • Marathi
  • Telugu
  • Tamil
  • Gujarati
  • Urdu
  • Kannada
  • Odia
  • Malayalam
  • Punjabi

p.s. current translations are done using google translate (google sheet's =GOOGLETRANSLATE()) so it's not going to be perfect can be improved with community support.

as most of the components had single quotes, I have added .editorconfig so editor can automatically detact that it's in single quotes

@vercel
Copy link

vercel bot commented Mar 25, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/covid19india/covid19india-react/hxs4ccnav
✅ Preview: https://covid19india-react-git-fork-harshzalavadiya-master.covid19india.now.sh

@abhishekkhandait
Copy link

abhishekkhandait commented Mar 25, 2020

IMHO translation for FAQs and banner is a must and it seems to be missing

@harshzalavadiya
Copy link
Contributor Author

harshzalavadiya commented Mar 25, 2020

Yes, @abhishekkhandait translations and banner is coming from JSON api back-end has to support translations or has to be moved to translation files

Update as of now to get translated JSON I have added lang query param to json calls

@vercel vercel bot requested a deployment to Preview March 25, 2020 22:55 Abandoned
@vercel
Copy link

vercel bot commented Mar 25, 2020

You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit c445948.

You can try again later or upgrade your plan.

@vercel vercel bot requested a deployment to Preview March 25, 2020 23:05 Abandoned
@vercel
Copy link

vercel bot commented Mar 25, 2020

You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit e9b6424.

You can try again later or upgrade your plan.

@vercel vercel bot requested a deployment to Preview March 25, 2020 23:25 Abandoned
@vercel
Copy link

vercel bot commented Mar 25, 2020

You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit 3df2ed3.

You can try again later or upgrade your plan.

@harshzalavadiya
Copy link
Contributor Author

Edit just now looked at https://github.com/covid19india/api apparently it's static json and seems to be coming from google sheets

one possible solution can be adding columns with question-en, answer-en etc. and generating multiple FAQ files like faq-en.json

being google sheet you can take advantage of GOOGLETRANSLATE function let it do it automatically

@harshzalavadiya
Copy link
Contributor Author

Well, I have resolved conflicts more then 3-4 times to keep branch up to date and it keeps on happening plus not sure if this is going to merge.
If it is going to merge then let me know I'll try to resolve conflicts otherwise I won't be pushing updates on this PR from now on as there's no response from core devs

IMHO as of now everyone is pushing commits and not following any formatting guidelines it will be worthwhile to add opinionated formatter like prettier so merge conflicts can be very minimal

Anyways thank you all devs of this repo this is an amazing project keep up the good work

@andante-9
Copy link

Do you need help with this? I can pick up some of the slack

@s-naveen
Copy link
Contributor

Well, I have resolved conflicts more then 3-4 times to keep branch up to date and it keeps on happening plus not sure if this is going to merge.
If it is going to merge then let me know I'll try to resolve conflicts otherwise I won't be pushing updates on this PR from now on as there's no response from core devs

IMHO as of now everyone is pushing commits and not following any formatting guidelines it will be worthwhile to add opinionated formatter like prettier so merge conflicts can be very minimal

Anyways thank you all devs of this repo this is an amazing project keep up the good work

@harshzalavadiya you should rebase over upstream and force push instead of merging that would keep commits clean.

@harshzalavadiya
Copy link
Contributor Author

harshzalavadiya commented Mar 26, 2020

@andante-9 I don't have any issues working on this PR, as of now there's nothing to be done as there's no input from the project maintainers. seems this is low priority as of now.

@s-naveen you might be right but I am no expert in git, and this PR is modifying most off the files and due to that it's generating conflict everytime, plus looks like each maintainers has it's own way of formatting files and due to that it just creates unnecessary diff that can easily be avoided.

update: there's already a PR adding eslint and prettier for this #192

@jeremyphilemon
Copy link
Collaborator

@harshzalavadiya hey really sorry, the devs didn't really expect a lot of incoming PRs at the time of release so we didn't think about settings up the style guidelines since it was only a very few people at first.

I'm closing this right now since I believe we've had major revisions to the codebase since this was opened – which I apologize due to the lack of time – but feel free to work on this again!

I've assigned you to #21 exclusively, I'll keep an eye out for your PR.

@harshzalavadiya
Copy link
Contributor Author

Sure I get it I'll submit an PR tomorrow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization for the app
6 participants