Skip to content
This repository has been archived by the owner on May 30, 2021. It is now read-only.

refactor: build site with rollup, share functions between scraper and site #191

Merged
merged 18 commits into from
Mar 20, 2020

Conversation

lazd
Copy link
Collaborator

@lazd lazd commented Mar 20, 2020

Things I'm doing here:

  • Use rollup to bundle site
  • Split out site pages into separate modules
  • Share dependencies between frontend and scraper
  • Refactor/regroup and move around many library functions
  • Figure out why editing index.html doesn't copy it
  • Live reload
  • Test deployment

Things we should still do after this PR:

  • A little more refactoring in site modules (cache querySelector calls)
  • Make the page refresh when data updated
  • Bundle mapboxgl, PapaParse, and handsontable?
  • Update README and getting started docs

Things I'm not doing here:

  • Using proper routing on the site
  • Making the site not suck

@lazd
Copy link
Collaborator Author

lazd commented Mar 20, 2020

@ryanblock @qgolsteyn can you take a look at this and just merge it if it's OK? We can finish up the rest of the todos later. Folks are contributing things like #188, #203, and @NateBaldwinDesign is working on the map, and I want to get this refactor out of their way.

Thanks!

@ryanblock
Copy link
Collaborator

cc @brianleroux

@qgolsteyn qgolsteyn marked this pull request as ready for review March 20, 2020 23:01
rollup.config.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@camjc camjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some potentially off-topic comments (just because moving lots of files so reading bits I hadn't before). Feel free to accept or reject and get this sucker in.

site/sources.js Outdated Show resolved Hide resolved
site/sources.js Outdated Show resolved Hide resolved
site/sources.js Outdated Show resolved Hide resolved
site/map.js Show resolved Hide resolved
site/map.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@camjc camjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lazd and others added 6 commits March 20, 2020 16:29
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
@lazd lazd changed the title Refactor site to use rollup refactor: build site with rollup, share functions between scraper and site Mar 20, 2020
@lazd lazd merged commit 8f7dca6 into master Mar 20, 2020
@lazd lazd deleted the rollup branch March 20, 2020 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants