This repository has been archived by the owner on May 30, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 183
refactor: build site with rollup, share functions between scraper and site #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ryanblock @qgolsteyn can you take a look at this and just merge it if it's OK? We can finish up the rest of the todos later. Folks are contributing things like #188, #203, and @NateBaldwinDesign is working on the map, and I want to get this refactor out of their way. Thanks! |
cc @brianleroux |
lazd
commented
Mar 20, 2020
camjc
reviewed
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some potentially off-topic comments (just because moving lots of files so reading bits I hadn't before). Feel free to accept or reject and get this sucker in.
camjc
reviewed
Mar 20, 2020
camjc
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
Co-Authored-By: Cameron Chamberlain <git@camjc.com>
lazd
changed the title
Refactor site to use rollup
refactor: build site with rollup, share functions between scraper and site
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I'm doing here:
index.html
doesn't copy itThings we should still do after this PR:
querySelector
calls)Things I'm not doing here: