This repository has been archived by the owner on May 30, 2021. It is now read-only.
ArcGIS pagination #889
Closed
ArcGIS pagination #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Larry Davis <lazdnet@gmail.com>
Co-Authored-By: Larry Davis <lazdnet@gmail.com>
Co-Authored-By: Emilio Graff <1@emil.io>
Co-Authored-By: Emilio Graff <1@emil.io>
Co-Authored-By: Emilio Graff <1@emil.io>
Co-Authored-By: Emilio Graff <1@emil.io>
|
Hi @shaperilio , my cache review was for this change:
You can (should be able to!) get rid of that by checking this branch out and updating that reference so it's referring to the same sha as in master. Ping if issues. :-) |
|
@camjc does this relate to the JP problem you noted? |
|
fyi @shaperilio and anyone else -- I've pulled parts of this over to Li in (wip) PR covidatlas/li#193, and implemented it for JP. @shaperilio I reused your work for that, thanks. We still have to implement the paging for all the scrapers that Emilio did in this PR, so I'm leaving this open until I create another issue in Li. |
|
New issue in Li covidatlas/li#350 covers the work in this PR, so I'm closing this one here. Thank you very much @shaperilio ! z |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to replace #835; I'm trying to address @jzohrab's comment about not updating the cache submodule, but to be honest, I can't see when it was done, or how to undo it.
This would address #832.
All scrapers were migrated and eye-tested.
I've defined a transition date so that we don't get cache misses when building timeseries. In this PR the date's been changed:
Please take a look if you haven't already looked at the old one. (Nothing's changed here other than bringing it up to date with master and changing the deploy date.