Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change flow for US to require region #108

Closed
awwaiid opened this issue Jun 8, 2020 · 1 comment
Closed

Change flow for US to require region #108

awwaiid opened this issue Jun 8, 2020 · 1 comment
Assignees
@reptile18
Projects
General Tasks
Milestone
Phase 2

Comments

@awwaiid
Copy link
Member

awwaiid commented Jun 8, 2020 •
edited

The phase2 data structure assumes that you've selected a state, so we need some sort of forced collection of this data.

After someone searches but before they get results, if the current region is all and you have more than one region, then we need have a pop-up with a drop-down to get the current region.

Probably use a modal dialog, https://vuetifyjs.com/en/components/dialogs/#modal

┆Issue is synchronized with this Trello card by Unito
@awwaiid awwaiid added this to the Phase 2 milestone Jun 8, 2020
@awwaiid awwaiid added this to To do in General Tasks via automation Jun 8, 2020
@reptile18 reptile18 self-assigned this Jul 24, 2020
reptile18 added a commit that referenced this issue Jul 24, 2020
@reptile18
add modal popup before searchresults [#108]
31b6f8d
reptile18 added a commit that referenced this issue Jul 24, 2020
@reptile18
correctly only show the popup if 'all' is selected and there are more…
97ffe55 
… regions [#108]
@reptile18 reptile18 mentioned this issue Jul 24, 2020
Closed
@awwaiid
Copy link
Member Author

awwaiid commented Jul 27, 2020

DONE! Thanks @reptile18

@awwaiid awwaiid closed this as completed Jul 27, 2020
General Tasks automation moved this from To do to Done Jul 27, 2020
This was referenced Apr 1, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reptile18 reptile18

Labels
None yet
Projects
General Tasks
  
Done
Milestone
Phase 2
Development

Successfully merging a pull request may close this issue.

Modal region selector covidcanidoit/covidcanidoit
2 participants
@awwaiid @reptile18