Refactor: use the <Card> atom in every component that displays a card #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p to the icon (used in CloseContactTracing to overlap the text and image)
andreaforni
commented
Aug 7, 2020
|
|
||
| export const CloseContactWarning: FC = () => { | ||
| const {t} = useTranslation(); | ||
| const navigation = useNavigation(); | ||
|
|
||
| return ( | ||
| <TouchableWithoutFeedback | ||
| <Card | ||
| padding={{v: 0, h: 0}} |
There was a problem hiding this comment.
I had to set the vertical padding to zero, even though the one set in styles.card was 16, to match the original design:
With vertical padding equal to 16, it would be:
ShaunBaker
approved these changes
Aug 11, 2020
floridemai
approved these changes
Aug 11, 2020
floridemai
reviewed
Aug 11, 2020
There was a problem hiding this comment.
@andreaforni Approved as it all looks good. I think you need to just resolve the conflicts around icons. Code looks good.
Thanks @floridemai, I'm already working on the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #25.
Cardatom:CloseContactWarning,TracingAvailable,TransmissionChart,CovidStats,CountyBreakdown, andSymptomChecker.StatsCardcomponent (components/molecules/stats-card.tsx).Cardatom to fix the design whentypeiswarning.