addOrUpdate geofences coercion, closes #84

.jshintrc

@@ -0,0 +1,34 @@
+{
+  "predef": [
+    "document",
+    "window",
+    "-Promise",
+    "require",
+    "module"
+  ],
+  "browser": true,
+  "boss": true,
+  "curly": true,
+  "debug": false,
+  "devel": true,
+  "eqeqeq": true,
+  "evil": true,
+  "forin": false,
+  "immed": false,
+  "laxbreak": false,
+  "newcap": true,
+  "noarg": true,
+  "noempty": false,
+  "nonew": false,
+  "nomen": false,
+  "onevar": false,
+  "plusplus": false,
+  "regexp": false,
+  "undef": true,
+  "sub": true,
+  "strict": false,
+  "white": false,
+  "eqnull": true,
+  "esnext": true,
+  "unused": true
+}

plugin.xml

@@ -43,7 +43,7 @@
         <source-file src="src/android/Notification.java" target-dir="src/com/cowbell/cordova/geofence" />
         <source-file src="src/android/ReceiveTransitionsIntentService.java" target-dir="src/com/cowbell/cordova/geofence" />
         <source-file src="src/android/RemoveGeofenceCommand.java" target-dir="src/com/cowbell/cordova/geofence" />
-		    
+
         <framework src="com.google.android.gms:play-services-location:+" />
         <lib-file src="src/android/libs/gson-2.3.jar" />
 

tests/.jshintrc

@@ -0,0 +1,36 @@
+{
+  "predef": [
+    "document",
+    "window",
+    "-Promise",
+    "require",
+    "module",
+    "exports"
+  ],
+  "jasmine": true,
+  "browser": true,
+  "boss": true,
+  "curly": true,
+  "debug": false,
+  "devel": true,
+  "eqeqeq": true,
+  "evil": true,
+  "forin": false,
+  "immed": false,
+  "laxbreak": false,
+  "newcap": true,
+  "noarg": true,
+  "noempty": false,
+  "nonew": false,
+  "nomen": false,
+  "onevar": false,
+  "plusplus": false,
+  "regexp": false,
+  "undef": true,
+  "sub": true,
+  "strict": false,
+  "white": false,
+  "eqnull": true,
+  "esnext": true,
+  "unused": true
+}

tests/tests.js

@@ -9,55 +9,49 @@ exports.defineAutoTests = function () {
         succeed = function (done) {
             expect(true).toBe(true);
             done();
-        },
-        geofence = {
-            id: '1',
-            latitude: 50,
-            longitude: 50,
-            radius: 1000,
-            transitionType: 1
-        },
-        geofence2 = {
-            id: '2',
-            latitude: 55,
-            longitude: 55,
-            radius: 1000,
-            transitionType: 1
         };
 
-    describe('Geofence plugin object', function () {
-        it('should be defined in window object', function () {
+    describe("Geofence plugin object", function () {
+        it("should be defined in window object", function () {
             expect(window.geofence).toBeDefined();
         });
 
-        it('should contain addOrUpdate function', function () {
+        it("should contain addOrUpdate function", function () {
             expect(window.geofence.addOrUpdate).toBeDefined();
-            expect(typeof window.geofence.addOrUpdate).toBe('function');
+            expect(typeof window.geofence.addOrUpdate).toBe("function");
         });
 
-        it('should contain initialize function', function () {
+        it("should contain initialize function", function () {
             expect(window.geofence.initialize).toBeDefined();
-            expect(typeof window.geofence.initialize).toBe('function');
+            expect(typeof window.geofence.initialize).toBe("function");
         });
 
-        it('should contain remove function', function () {
+        it("should contain remove function", function () {
             expect(window.geofence.remove).toBeDefined();
-            expect(typeof window.geofence.remove).toBe('function');
+            expect(typeof window.geofence.remove).toBe("function");
         });
 
-        it('should contain removeAll function', function () {
+        it("should contain removeAll function", function () {
             expect(window.geofence.removeAll).toBeDefined();
-            expect(typeof window.geofence.removeAll).toBe('function');
+            expect(typeof window.geofence.removeAll).toBe("function");
         });
 
-        it('should contain getWatched function', function () {
+        it("should contain getWatched function", function () {
             expect(window.geofence.getWatched).toBeDefined();
-            expect(typeof window.geofence.getWatched).toBe('function');
+            expect(typeof window.geofence.getWatched).toBe("function");
         });
     });
 
-    describe('removeAll function', function () {
-        it('should remove all stored geofences', function (done) {
+    describe("removeAll function", function () {
+        it("should remove all stored geofences", function (done) {
+            var geofence = {
+                id: "1",
+                latitude: 50,
+                longitude: 50,
+                radius: 1000,
+                transitionType: 1
+            };
+
             window.geofence.addOrUpdate(geofence)
                 .then(window.geofence.removeAll)
                 .then(window.geofence.getWatched)
@@ -70,41 +64,160 @@ exports.defineAutoTests = function () {
         });
     });
 
-    describe('addOrUpdate function', function () {
-        beforeEach(function () {
+    describe("addOrUpdate function", function () {
+        var geofence, geofence2;
 
+        beforeEach(function () {
+            geofence = {
+                id: "1",
+                latitude: 50,
+                longitude: 50,
+                radius: 1000,
+                transitionType: 1
+            },
+            geofence2 = {
+                id: "2",
+                latitude: 55,
+                longitude: 55,
+                radius: 1000,
+                transitionType: 1
+            };
         });
 
         afterEach(function () {
             window.geofence.removeAll();
         });
 
-        it('should add single geofence', function (done) {
+        it("should add single geofence", function (done) {
             window.geofence
                 .addOrUpdate(geofence)
                 .then(window.geofence.getWatched)
                 .then(function (geofencesJson) {
                     var geofences = JSON.parse(geofencesJson);
-                    expect(geofences[0].id).toBe('1');
+                    expect(geofences[0].id).toBe("1");
                     done();
                 })
                 .catch(fail.bind(this, done));
         });
 
-        it('should add array of geofences', function (done) {
+        it("should add array of geofences", function (done) {
             window.geofence
                 .addOrUpdate([geofence, geofence2])
                 .then(window.geofence.getWatched)
                 .then(function (geofencesJson) {
                     var geofences = JSON.parse(geofencesJson);
                     expect(geofences.length).toBe(2);
-                    expect(geofences.filter(filterById('1'))[0].id).toBe('1');
-                    expect(geofences.filter(filterById('2'))[0].id).toBe('2');
+                    expect(geofences.filter(filterById("1"))[0].id).toBe("1");
+                    expect(geofences.filter(filterById("2"))[0].id).toBe("2");
                     done();
                 })
                 .catch(fail.bind(this, done));
         });
 
+        describe("geofence object coercion", function () {
+            it("should throw an error if id is not provided", function (done) {
+                geofence.id = undefined;
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrowError("Geofence id is not provided");
+                done();
+            });
+
+            it("should throw an error if latitude is not provided", function (done) {
+                geofence.latitude = undefined;
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Geofence latitude is not provided"));
+                done();
+            });
+
+            it("should throw an error if latitude can't be converted to number", function (done) {
+                geofence.latitude = "somestring";
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Cannot convert Geofence latitude to number"));
+                done();
+            });
+
+            it("should convert latitude to number if possible", function (done) {
+                geofence.latitude = "50.5";
+
+                window.geofence.addOrUpdate(geofence)
+                    .then(function () {
+                        expect(geofence.latitude).toBe(50.5);
+                        done();
+                    });
+            });
+
+            it("should throw an error if longitude is not provided", function (done) {
+                geofence.longitude = undefined;
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Geofence longitude is not provided"));
+                done();
+            });
+
+            it("should throw an error if longitude can't be converted to number", function (done) {
+                geofence.longitude = "somestring";
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Cannot convert Geofence longitude to number"));
+                done();
+            });
+
+            it("should throw an error if radius is not provided", function (done) {
+                geofence.radius = undefined;
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Geofence radius is not provided"));
+                done();
+            });
+
+            it("should throw an error if radius can't be converted to number", function (done) {
+                geofence.radius = "somestring";
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Cannot convert Geofence radius to number"));
+                done();
+            });
+
+            it("should throw an error if transitionType is not provided", function (done) {
+                geofence.transitionType = undefined;
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Geofence transitionType is not provided"));
+                done();
+            });
+
+            it("should throw an error if transitionType can't be converted to number", function (done) {
+                geofence.transitionType = "somestring";
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Cannot convert Geofence transitionType to number"));
+                done();
+            });
+
+            it("should throw an error if notification.vibration is not an Array", function (done) {
+                geofence.notification = {
+                    vibration: "somestring"
+                };
+
+                expect(function () {
+                    window.geofence.addOrUpdate(geofence);
+                }).toThrow(new Error("Geofence notification.vibration is not an Array"));
+                done();
+            });
+
+        });
     });
 
     function filterById(id) {
@@ -115,7 +228,7 @@ exports.defineAutoTests = function () {
 };
 
 exports.defineManualTests = function (contentEl, createActionButton) {
-    // createActionButton('Test button', function () {
-    //     console.log('Test button clicked');
+    // createActionButton("Test button", function () {
+    //     console.log("Test button clicked");
     // });
 };