Added support for DSM 7 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madereddy
reviewed
Jul 3, 2021
There was a problem hiding this comment.
Tested this on DSM 7 and it is working correct.
Checking for a Plex Media Server update...
[ Retrieving DSM version ]
Found DSM version 7
[ Enabling Plex Pass releases ]
Found Plex Token
[ Retrieving version data ]
Available version: 1.23.4.4712-1f0ed4aea
Installed version: 1.23.4.4712-7000
The installed version of Plex is newer than the available version. If you have Plex Pass, be sure to run this script with the --plex-pass option.
Plex is up-to-date.
Done!
|
The latest file isn't yet updated with this change, when I pull from this URL, the script does not work on DSM 7 |
|
Hi @epheterson, the latest release has not been updated with the changes made in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSM 7 comes with two changes:
PlexMediaServerinstead ofPlex Media Server, which causes thesynopkgcalls to fail.Synology (DSM 7).I've added a new function called
retrieve_dsm_versionthat check wether the DSM version is <6 or 7. The subsequent calls are then adapted to the right DSM version.Important note: I could only test this on DSM 7 (DS920+), can someone test the PR on DSM 6 to check that everything is still working as intended ?