Make Handlebars::Context.current thread safe #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeychich
force-pushed
the
thread-safe-context
branch
from
9af64c8
to
ceb0510
Compare
Handlebars::Template#call was mutating global state. When called in multiple threads you ran the risk of overwriting the current context for other threads while the @fn.call was executing. By moving to a thread variable we ensure that this value remains with the thread which is setting the value. Also in this PR are some dependency updates including requiring a modern ruby. All three ruby versions previously tested are no longer maintained.
mpeychich
force-pushed
the
thread-safe-context
branch
from
82237d9
to
7dce38c
Compare
|
@cowboyd Any thoughts on this? I'd love to get this merged in. I am not familiar with the versioning change needed here since it does bump the required ruby version, but it does so by requiring the minimum maintained version (lower than that even) where there was no minimum previously. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlebars::Template#call was mutating global state. When called in
multiple threads you ran the risk of overwriting the current context for
other threads while the @fn.call was executing. By moving to a thread
variable we ensure that this value remains with the thread which is
setting the value.
Also in this PR are some dependency updates including requiring a modern
ruby. All three ruby versions previously tested are no longer
maintained.
Should address #39