Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA 0.12 is not compatible with k8s 1.21 #345

Closed
cartucciam opened this issue Nov 24, 2022 · 6 comments
Closed

VPA 0.12 is not compatible with k8s 1.21 #345

cartucciam opened this issue Nov 24, 2022 · 6 comments

Comments

@cartucciam
Copy link

cartucciam commented Nov 24, 2022

794c87e updates the chart to v6 and the app to 0.12 but 0.12 is only compatible with 1.25+ whereas the chart claims 1.21 support

https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler#compatibility

@sebastien-prudhomme
Copy link
Contributor

Hi @cartucciam, the official doc is not always correct.

I can confirm that the recommender is working fine on version 1.21. The updater seems to need version 1.22.

On what version of Kubernetes have you seen a problem?

@cartucciam
Copy link
Author

cartucciam commented Nov 25, 2022

Hi @sebastien-prudhomme, thanks for answering this, we had issues running the chart on
1.21, the eviction stopped working complaining of a legacy API version.

If the updater seems to need version 1.22 why the chart targets k8s >= 1.21 and uses 0.12 as default for its image?

@cartucciam
Copy link
Author

cartucciam commented Nov 29, 2022

We fixed this by setting the updater image back to 0.9.2. The issue remains though as the default values of the chart aren't consistent with its targeting 1.21+

@brsolomon-deloitte
Copy link

brsolomon-deloitte commented Dec 14, 2022

Confirming this was an issue for us also in that the image tag 0.12.0 broke on Kubernetes 1.21 (as the vertical-pod-autoscaler docs disclose that they will); we needed to set

vertical-pod-autoscaler:
  admissionController:
    image:
      tag: 0.9.2
  updater:
    image:
      tag: 0.9.2
  recommender:
    image:
      tag: 0.9.2

otherwise, the updater was failing to evict pods:

evicting pod hamster-96d4585b7-8blzn failed: Eviction in version "v1" cannot be handled as a Eviction: no kind "Eviction" is registered for version "policy/v1" in scheme "k8s.io/kubernetes/pkg/api/legacyscheme/scheme.go:30"

@sebastien-prudhomme
Copy link
Contributor

I've fixed the Kubernetes minimum version in #349.

@cartucciam
Copy link
Author

I've fixed the Kubernetes minimum version in #349.

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants