Bubble up float approximation of minValueUsd

cowprotocol · Apr 16, 2024 · def777c · def777c
1 parent 8b7fd63
commit def777c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/tasks/selfSell.ts b/src/tasks/selfSell.ts
@@ -973,7 +973,7 @@ const setupSelfSellTask: () => void = () =>
           tokens = await getTokensWithBalanceAbove({
             chainId,
             settlementContract: settlementDeployment.address,
-            minValueUsd: minValue,
+            minValueUsd: parseInt(minValue),
           });
         }
         // Exclude the toToken if needed, as we can not sell it for itself (buyToken is not allowed to equal sellToken)

diff --git a/src/tasks/withdraw/token_balances.ts b/src/tasks/withdraw/token_balances.ts
@@ -1,7 +1,7 @@
 import axios from "axios";
 
 export interface GetTokensInput {
-  minValueUsd: string;
+  minValueUsd: number;
   settlementContract: string;
   chainId: number;
 }
@@ -43,7 +43,7 @@ interface EthplorerAddressInfoResponse {
 }
 
 export async function getMainnetTokensWithBalanceAbove(
-  minValueUsd: string,
+  minValueUsd: number,
   settlementContract: string,
 ): Promise<string[]> {
   const response = await axios.get(
@@ -58,7 +58,7 @@ export async function getMainnetTokensWithBalanceAbove(
     const tokenUsdValue =
       token.tokenInfo.price.rate *
       (token.balance / Math.pow(10, token.tokenInfo.decimals));
-    if (tokenUsdValue > parseInt(minValueUsd)) {
+    if (tokenUsdValue > minValueUsd) {
       result.push(token.tokenInfo.address);
     }
   }
@@ -76,7 +76,7 @@ interface BlockscoutSingleTokenInfo {
 }
 
 export async function getGnosisChainTokensWithBalanceAbove(
-  minValueUsd: string,
+  minValueUsd: number,
   settlementContract: string,
 ): Promise<string[]> {
   const response = await axios.get(
@@ -91,7 +91,7 @@ export async function getGnosisChainTokensWithBalanceAbove(
     const tokenUsdValue =
       parseFloat(token.exchange_rate) *
       (parseInt(value) / Math.pow(10, parseInt(token.decimals)));
-    if (tokenUsdValue > parseInt(minValueUsd)) {
+    if (tokenUsdValue > minValueUsd) {
       result.push(token.address);
     }
   }