Bump Node version to 18 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4676450328
💛 - Coveralls |
bh2smith
approved these changes
Apr 12, 2023
|
FYI: I also had to update the required status check in the repo settings to use Node v18 instead of Node v16. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Node 14 when building the Docker image for this repo, which causes CI to fail after the latest dependency updates.
Node 14 leaves maintenance mode this month (see release schedule) and is then technically unsupported. Version 16 will be unsupported by October this year as well.
This PR switches all versions of Node in CI to 18.
Test Plan
CI and
docker build -f src/docker/Dockerfile ..