Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composable cow #140

Merged
merged 21 commits into from
Aug 16, 2023
Merged

Composable cow #140

merged 21 commits into from
Aug 16, 2023

Conversation

mfw78
Copy link
Collaborator

@mfw78 mfw78 commented Aug 9, 2023 •
edited
Loading

This PR:

  1. Provides typedoc for all existing functions.
  2. Adds support for ComposableCoW primitives including:
    a. BaseConditionalOrder classes for order types to inherit from.
    b. Multiplexer methods allowing for generating Merkle Trees of orders.

Outstanding items (to be handled in separate PR):

@coveralls
Copy link
Collaborator

coveralls commented Aug 9, 2023 •
edited
Loading

Coverage Status

coverage: 81.541% (+8.6%) from 72.93% when pulling 0623bc6 on composable-cow into 3abfdcf on main.

@socket-security
Copy link

socket-security bot commented Aug 9, 2023 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-unused-imports 3.0.0 None +1 28.6 kB sweepline
@openzeppelin/merkle-tree 1.0.5 None +6 1.24 MB frangio
typechain 8.3.1 filesystem +19 1.48 MB ethereum-ts-bot
@typechain/ethers-v5 11.1.1 filesystem +20 1.57 MB ethereum-ts-bot
@graphql-codegen/typescript-operations 3.0.0...3.0.4 None +27/-17 4.11 MB dotansimha

@mfw78 mfw78 requested review from anxolin and alfetopito and removed request for anxolin August 9, 2023 10:16
alfetopito
alfetopito reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, excellent documentation and testing work.

I have a few nitpicks, comments and questions

abi/ComposableCoW.json Outdated Show resolved Hide resolved
src/common/consts.ts Outdated Show resolved Hide resolved
src/composable/conditionalorder.spec.ts Outdated Show resolved Hide resolved
src/composable/conditionalorder.spec.ts Show resolved Hide resolved
src/composable/index.ts Outdated Show resolved Hide resolved
src/composable/multiplexer.ts Outdated Show resolved Hide resolved
src/composable/types/twap.ts Outdated Show resolved Hide resolved
src/composable/types/twap.ts Outdated Show resolved Hide resolved
src/composable/types/twap.ts Outdated Show resolved Hide resolved
src/order-signing/orderSigningUtils.ts Outdated Show resolved Hide resolved
@mfw78 mfw78 self-assigned this Aug 16, 2023
alfetopito
alfetopito approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

2 comments which are not blockers

src/composable/multiplexer.ts Outdated Show resolved Hide resolved
src/composable/multiplexer.ts Outdated Show resolved Hide resolved
shoom3301
shoom3301 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfw78 mfw78 merged commit d682769 into main Aug 16, 2023
8 checks passed
@mfw78 mfw78 deleted the composable-cow branch August 16, 2023 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

@anxolin anxolin Awaiting requested review from anxolin

Assignees

@mfw78 mfw78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfw78 @coveralls @alfetopito @shoom3301