-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): creating an order via smart-contract wallet #185
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
6c18cff
to
9ded2b1
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Also great test to later try to remove those dev-dependencies
"crypto": "npm:crypto-browserify@3.12.0", | ||
"stream": "npm:stream-browserify@3.0.0", | ||
"url": "npm:url@0.11.3", | ||
"util": "npm:util@0.12.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are all the libs u mentioned we depend on?
This is what you plan to improve? is the final outcome that we don't need to add any of these dev dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was talking about them.
But I've discovered that they actually came from @safe-global/api-kit
and @safe-global/protocol-kit
.
So, there is no problem with SDK itself.
I've tried to up Safe libs versions but haven't succeed, because they are using ethers@6.x.x.
In conclusion:
- cow-sdk is good, no issues there
- Safe libs with ethers@5.x.x have issues with node lbs
- we can't update Safe libs because new versions are based on ethers@6.x.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups!, I see 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it prefixed with npm:
?
Example for creating pre-signed order.
This example will be used for the docs: cowprotocol/docs#9
Demo:
presign-demo.mov