Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update orderbook api types #201

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: update orderbook api types #201

merged 2 commits into from
Mar 6, 2024

Conversation

alfetopito
Copy link
Contributor

Summary

Update to latest backend release

@alfetopito alfetopito self-assigned this Mar 5, 2024
@alfetopito alfetopito requested a review from a team March 5, 2024 11:32
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 78.851%. remained the same
when pulling e7c7453 on feat/update-orderbook-api-types
into 3d3e9f5 on main.

anxolin
anxolin reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can enforce we use the latest? should we have a githook or sth?

@alfetopito
Copy link
Contributor Author

Is there a way we can enforce we use the latest? should we have a githook or sth?

We talked about this the other day https://cowservices.slack.com/archives/C0361CDG8GP/p1708014605221669 and #200 (comment)

I prefer the current process as we update as needed.

@alfetopito alfetopito requested a review from a team March 5, 2024 17:01
@alfetopito alfetopito mentioned this pull request Mar 5, 2024
Closed
6 tasks
@alfetopito alfetopito merged commit e5bedea into main Mar 6, 2024
9 checks passed
@alfetopito alfetopito deleted the feat/update-orderbook-api-types branch March 6, 2024 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@shoom3301 shoom3301 shoom3301 approved these changes

@mfw78 mfw78 mfw78 approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alfetopito @coveralls @anxolin @shoom3301 @mfw78