Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix partner fee amount calculation #212

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix: fix partner fee amount calculation #212

merged 2 commits into from
Jun 13, 2024

Conversation

shoom3301
Copy link
Contributor

I just messed up with formula 🤦‍♂️
Instead of fee = amount * percent / 100 I did fee = amount / percent

image

@shoom3301 shoom3301 requested a review from a team June 13, 2024 12:56
@shoom3301 shoom3301 self-assigned this Jun 13, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 79.583% (+0.02%) from 79.56%
when pulling 13c38ac on fix/parner-fee-formula
into 5bf923b on main.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 79.583% (+0.02%) from 79.56%
when pulling 13c38ac on fix/parner-fee-formula
into 5bf923b on main.

@shoom3301 shoom3301 merged commit 5aa61a0 into main Jun 13, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 79.583% (+0.02%) from 79.56%
when pulling 62e70df on fix/parner-fee-formula
into 5bf923b on main.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 79.583% (+0.02%) from 79.56%
when pulling 62e70df on fix/parner-fee-formula
into 5bf923b on main.

@alfetopito alfetopito deleted the fix/parner-fee-formula branch June 17, 2024 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@shoom3301 shoom3301

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shoom3301 @coveralls