Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runQuery accept a DocumentNode #24

Merged
merged 3 commits into from
May 26, 2022
Merged

Make runQuery accept a DocumentNode #24

merged 3 commits into from
May 26, 2022

Conversation

ramirotw
Copy link
Contributor

@ramirotw ramirotw commented May 23, 2022

Right now the runQuery method only accepts a string and doesn't accept a DocumentNode when the query is parsed through Apollo's gql function, this forces the caller to cast the query as in https://github.com/cowprotocol/explorer/pull/93/files#diff-02bebd690fca011b032ac0e74e3286c0d751bc1f454eb09492f6aaac0c2d0ed3R50

@github-actions
Copy link

github-actions bot commented May 23, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2022

Coverage Status

Coverage remained the same at 77.707% when pulling 5fbcda7 on ramirotw/improve-type into 3a7e90d on main.

src/api/cow/index.ts Outdated Show resolved Hide resolved
This reverts commit e87cf04.
@ramirotw ramirotw merged commit 6994903 into main May 26, 2022
@ramirotw ramirotw deleted the ramirotw/improve-type branch May 26, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants