-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cowswap332/fix ipfs uploading #31
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
the coveralls fail comes from the src/utils/ipfs.ts
file you modified and for which we don't have any tests?
My changes are covered by unit tests, but due to a few extra lines added it's counting as overall coverage decreased I'll take another look to add more unittests, probably on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soft approve
7343863
to
5453256
Compare
Summary
Part of cowprotocol/cowswap#332
Fixing 2 main issues:
Also:
appData
- no longer only affiliate relatedversion
field as part ofquote
schemaTesting
yalc