0xError tests #48
Merged
0xError tests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
matextrem
approved these changes
Jul 12, 2022
alfetopito
reviewed
Jul 13, 2022
W3stside
force-pushed
the
0x-api-error-tests
branch
from
caf22ad
to
ffc2af8
Compare
W3stside
force-pushed
the
0x-api-error-tests
branch
from
ffc2af8
to
0a04b07
Compare
alfetopito
reviewed
Jul 14, 2022
W3stside
force-pushed
the
0x-api-error-tests
branch
from
0a04b07
to
633d181
Compare
ramirotw
approved these changes
Jul 14, 2022
W3stside
added a commit
that referenced
this pull request
Jul 18, 2022
* removed unnecessary code + minor test * adding 0x API pt.1 * adding 0x types simplify logic update add types * add utils to normalise quote * add zeroxApi * add zeroXSDK * tests fix 0x spec rebase fix remove test re-added during rebase fix constructor & getQuote + rearrange * add ZeroXError * add error test update tests * update 0xError handling * add zero0x api to cowsdk * pr comments * pass chainId to 0x api * update test * create separate utils file for 0x * update affiliateAddressMap type * modify api to address PR comments * 0xError tests (#48) * 0x error tests * fix test to use cowsdk * fix tests according to comments * better tests
W3stside
added a commit
that referenced
this pull request
Jul 18, 2022
* create BaseApi * CowApi extends BaseApi - pass base url and name in constructor - baseUrl includes api version - remove base fns from CowApi * removed unnecessary code + minor test * fix test to use BaseApi * revert type * add defaultHeaders to constructor and as optional params to fetch * remove appId check in tests * remove useless base spec test * add market util * fix small error * SIMPLIFY AND RENAME * fix small changes post merge * protect methods * add market utils test * simplify/organise baseApi * organise & override Cow/BaseApi methods * add option to override apiUrl params * fix private 'this' type * reqOptions > requestOptions * Add 0xApi & Errors (#47) * removed unnecessary code + minor test * adding 0x API pt.1 * adding 0x types simplify logic update add types * add utils to normalise quote * add zeroxApi * add zeroXSDK * tests fix 0x spec rebase fix remove test re-added during rebase fix constructor & getQuote + rearrange * add ZeroXError * add error test update tests * update 0xError handling * add zero0x api to cowsdk * pr comments * pass chainId to 0x api * update test * create separate utils file for 0x * update affiliateAddressMap type * modify api to address PR comments * 0xError tests (#48) * 0x error tests * fix test to use cowsdk * fix tests according to comments * better tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the 0xError class
Added this based on the 0x error doc