Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modules in nodejs #51

Merged
merged 6 commits into from
Jul 22, 2022
Merged

Support modules in nodejs #51

merged 6 commits into from
Jul 22, 2022

Conversation

ramirotw
Copy link
Contributor

@ramirotw ramirotw commented Jul 19, 2022 •
edited

@coveralls
Copy link
Collaborator

coveralls commented Jul 19, 2022 •
edited

Coverage Status

Coverage remained the same at 77.241% when pulling ea93882 on ramirotw/mjs-test into 89aae8e on main.

@github-actions
Copy link

github-actions bot commented Jul 19, 2022 •
edited

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

ramirotw
ramirotw commented Jul 19, 2022
View reviewed changes
.babelrc
}
]
],
"presets": [["@babel/preset-env", { "targets": { "node": "current" } }], "@babel/preset-typescript"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the babel.config.js file to unify all the babel config on this file

src/api/base/index.ts Show resolved Hide resolved
src/constants/index.ts Show resolved Hide resolved
@ramirotw ramirotw mentioned this pull request Jul 19, 2022
Closed
alfetopito
alfetopito approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome detective work, Ramiro!

package.json Show resolved Hide resolved
@ramirotw ramirotw requested a review from matextrem July 20, 2022 14:37
matextrem
matextrem approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@matextrem matextrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! 🎉

@ramirotw ramirotw merged commit d586507 into main Jul 22, 2022
@ramirotw ramirotw deleted the ramirotw/mjs-test branch July 22, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@matextrem matextrem matextrem approved these changes

@W3stside W3stside W3stside approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package not working when using node
5 participants
@ramirotw @coveralls @alfetopito @matextrem @W3stside