Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add price/quote legacy utility fns #61

Closed
wants to merge 18 commits into from
Closed

Add price/quote legacy utility fns #61

wants to merge 18 commits into from

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Jul 27, 2022 •
edited
Loading

utils/prices legacy utility functions

TODO

  • tests

@coveralls
Copy link
Collaborator

coveralls commented Jul 27, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-11.3%) to 64.46% when pulling 58b6a0b on price-util-functions into 3a13412 on proper-cowsdk-types.

@github-actions
Copy link

github-actions bot commented Jul 27, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@W3stside W3stside force-pushed the price-util-functions branch 5 times, most recently from d430581 to 515f79b Compare July 28, 2022 09:14
Base automatically changed from proper-cowsdk-types to optional-enable-apis August 2, 2022 08:36
Base automatically changed from optional-enable-apis to main August 2, 2022 08:41
@W3stside W3stside marked this pull request as ready for review August 2, 2022 14:46
@alfetopito
Copy link
Contributor

@W3stside some conflicts with main. I'll review after they are fixed

@alfetopito alfetopito closed this Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramirotw ramirotw Awaiting requested review from ramirotw

@alfetopito alfetopito Awaiting requested review from alfetopito

Assignees
No one assigned
Labels
on-hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@W3stside @coveralls @alfetopito