Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨ Improvement] Add an option to choose which event type to log on telegram output plugin #2122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ebanDev
Copy link

@ebanDev ebanDev commented Mar 5, 2024

No description provided.

@micheloosterhof
Copy link
Member

Hello! Thanks for this. Instead of having individual options, why don't we have a setting for included or excluded eventtypes that you do or don't want to send to Telegram? That'll be more straightforward than all these individual options.

@ebanDev
Copy link
Author

ebanDev commented Mar 9, 2024

Okay I agree with you ! I changed it ;)

@micheloosterhof
Copy link
Member

Did you test this and does it work? If you do this:
events_logged_list: list[str] = self.events_logged.split(",")
Does it also remove the whitespace in your example config file? Or does it need to be comma-separated with no whitespace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants